fix(js): free native strings #238
Conversation
Signed-off-by: Ariel Gentile <[email protected]>
| @@ -723,6 +726,8 @@ export class NodeJSAnoncreds implements Anoncreds { | |||
| const returnValue = handleReturnPointer<{ data: Buffer; len: number }>(ret) | |||
| const output = new Uint8Array(byteBufferToBuffer(returnValue)) | |||
|
|
|||
| this.nativeAnoncreds.anoncreds_buffer_free(returnValue.data) | |||
There was a problem hiding this comment.
Is a buffer also copied and not a ref?
There was a problem hiding this comment.
I've just done an update there because when creating an Uint8Array from a Buffer (this case in line 727) simply a new view is created, meaning (if I understand correctly) that no data is copied.
So I think it is safer to do this buffer free right after doing the text decoding and outputting to a string (which effectively copies the data).
There was a problem hiding this comment.
It would depend on how ffi-napi ref-napi handles this. It seems to me that they copy the data, but I haven't checked the code, yet.
Signed-off-by: Ariel Gentile <[email protected]>
Signed-off-by: Ariel Gentile <[email protected]>
I couldn't test it deeply but I've updated those template |
Absolutely! I was looking at the release notes and |
Not completely sure if it's the right approach (especially in react-native) but here is a simple attempt to free strings automatically in JS wrappers before returning to the caller, as discussed in #236.